From 192cf0bb12857c45b2d5ee06f7a9c7217ec09beb Mon Sep 17 00:00:00 2001 From: Shreyas Zare Date: Sat, 29 May 2021 12:23:04 +0530 Subject: [PATCH] CacheZoneManager: fixed null ref exception bug. --- .../Dns/ZoneManagers/CacheZoneManager.cs | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/DnsServerCore/Dns/ZoneManagers/CacheZoneManager.cs b/DnsServerCore/Dns/ZoneManagers/CacheZoneManager.cs index e07628ae..0e48f7c7 100644 --- a/DnsServerCore/Dns/ZoneManagers/CacheZoneManager.cs +++ b/DnsServerCore/Dns/ZoneManagers/CacheZoneManager.cs @@ -295,10 +295,13 @@ namespace DnsServerCore.Dns.ZoneManagers if (firstRR.IsStale) firstRR.ResetExpiry(30); //reset expiry by 30 seconds so that resolver tries again only after 30 seconds as per draft-ietf-dnsop-serve-stale-04 - foreach (DnsResourceRecord record in dnsEmptyRecord.Authority) + if (dnsEmptyRecord.Authority is not null) { - if (record.IsStale) - record.ResetExpiry(30); //reset expiry by 30 seconds so that resolver tries again only after 30 seconds as per draft-ietf-dnsop-serve-stale-04 + foreach (DnsResourceRecord record in dnsEmptyRecord.Authority) + { + if (record.IsStale) + record.ResetExpiry(30); //reset expiry by 30 seconds so that resolver tries again only after 30 seconds as per draft-ietf-dnsop-serve-stale-04 + } } } @@ -312,10 +315,13 @@ namespace DnsServerCore.Dns.ZoneManagers if (firstRR.IsStale) firstRR.ResetExpiry(30); //reset expiry by 30 seconds so that resolver tries again only after 30 seconds as per draft-ietf-dnsop-serve-stale-04 - foreach (DnsResourceRecord record in dnsNXRecord.Authority) + if (dnsNXRecord.Authority is not null) { - if (record.IsStale) - record.ResetExpiry(30); //reset expiry by 30 seconds so that resolver tries again only after 30 seconds as per draft-ietf-dnsop-serve-stale-04 + foreach (DnsResourceRecord record in dnsNXRecord.Authority) + { + if (record.IsStale) + record.ResetExpiry(30); //reset expiry by 30 seconds so that resolver tries again only after 30 seconds as per draft-ietf-dnsop-serve-stale-04 + } } }