fergalmoran/Readarr
1
0
Fork 0
mirror of https://github.com/fergalmoran/Readarr.git synced 2025-12-22 09:29:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enforce rule IDE0005 on build

Browse Source 
(cherry picked from commit 6b1e4ef81938d264a2ddc8b626b0502f799aa640)

Closes #2555
This commit is contained in:
Bogdan
2023-05-28 02:53:49 +03:00
parent 0a43481aed
commit c98f4512df
6 changed files with 47 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Directory.Build.props
View File

@@ -30,6 +30,13 @@
<!-- A test project gets the test sdk packages automatically added --> <!-- A test project gets the test sdk packages automatically added -->
<TestProject>false</TestProject> <TestProject>false</TestProject>
<TestProject Condition="$(MSBuildProjectName.EndsWith('.Test'))">true</TestProject> <TestProject Condition="$(MSBuildProjectName.EndsWith('.Test'))">true</TestProject>
<!-- XML documentation comments are needed to enforce rule IDE0005 on build -->
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<!--
CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'
-->
<NoWarn>$(NoWarn);CS1591</NoWarn>
</PropertyGroup> </PropertyGroup>
<PropertyGroup> <PropertyGroup>

2
src/NzbDrone.Common/Extensions/BerghelRoach.cs
View File

@@ -369,7 +369,7 @@ namespace NzbDrone.Common.Extensions
* *
* This is the "f" function described by Ukkonen. * This is the "f" function described by Ukkonen.
* *
* The caller must assure that abs(k) &le; p, the only values for * The caller must assure that abs(k) &#x2264; p, the only values for
* which this is well-defined. * which this is well-defined.
* *
* The implementation depends on the cached results of prior * The implementation depends on the cached results of prior

2
src/NzbDrone.Common/OAuth/OAuthRequest.cs
View File

@@ -29,7 +29,7 @@ namespace NzbDrone.Common.OAuth
public virtual string Version { get; set; } public virtual string Version { get; set; }
public virtual string SessionHandle { get; set; } public virtual string SessionHandle { get; set; }
/// <seealso cref="http://oauth.net/core/1.0#request_urls"/> /// <seealso href="http://oauth.net/core/1.0#request_urls"/>
public virtual string RequestUrl { get; set; } public virtual string RequestUrl { get; set; }
public virtual Dictionary<string, string> Parameters { get; set; } public virtual Dictionary<string, string> Parameters { get; set; }

10
src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs
View File

@@ -35,13 +35,13 @@ namespace NzbDrone.Core.Indexers.TorrentRss
/// </summary> /// </summary>
/// <param name="settings">Indexer Settings to use for Parser</param> /// <param name="settings">Indexer Settings to use for Parser</param>
/// <returns>Parsed Settings or <c>null</c></returns> /// <returns>Parsed Settings or <c>null</c></returns>
public TorrentRssIndexerParserSettings Detect(TorrentRssIndexerSettings indexerSettings) public TorrentRssIndexerParserSettings Detect(TorrentRssIndexerSettings settings)
{ {
_logger.Debug("Evaluating TorrentRss feed '{0}'", indexerSettings.BaseUrl); _logger.Debug("Evaluating TorrentRss feed '{0}'", settings.BaseUrl);
try try
{ {
var requestGenerator = new TorrentRssIndexerRequestGenerator { Settings = indexerSettings }; var requestGenerator = new TorrentRssIndexerRequestGenerator { Settings = settings };
var request = requestGenerator.GetRecentRequests().GetAllTiers().First().First(); var request = requestGenerator.GetRecentRequests().GetAllTiers().First().First();
HttpResponse httpResponse = null; HttpResponse httpResponse = null;
@@ -56,11 +56,11 @@ namespace NzbDrone.Core.Indexers.TorrentRss
} }
var indexerResponse = new IndexerResponse(request, httpResponse); var indexerResponse = new IndexerResponse(request, httpResponse);
return GetParserSettings(indexerResponse, indexerSettings); return GetParserSettings(indexerResponse, settings);
} }
catch (Exception ex) catch (Exception ex)
{ {
ex.WithData("FeedUrl", indexerSettings.BaseUrl); ex.WithData("FeedUrl", settings.BaseUrl);
throw; throw;
} }
} }

6
src/NzbDrone.Core/MetadataSource/Goodreads/Resources/ReviewResource.cs
View File

@@ -40,9 +40,9 @@ namespace NzbDrone.Core.MetadataSource.Goodreads
/// </summary> /// </summary>
public string SpoilersState { get; protected set; } public string SpoilersState { get; protected set; }
/// <summary> // /// <summary>
/// The shelves the user has added this review to. // /// The shelves the user has added this review to.
/// </summary> // /// </summary>
// public IReadOnlyList<ReviewShelf> Shelves { get; protected set; } // public IReadOnlyList<ReviewShelf> Shelves { get; protected set; }
/// <summary> /// <summary>

6
src/NzbDrone.Core/MetadataSource/Goodreads/Resources/UserShelfResource.cs
View File

@@ -41,9 +41,9 @@ namespace NzbDrone.Core.MetadataSource.Goodreads
/// </summary> /// </summary>
public string Sort { get; private set; } public string Sort { get; private set; }
/// <summary> // /// <summary>
/// Determines the default sort order of this user shelf. // /// Determines the default sort order of this user shelf.
/// </summary> // /// </summary>
// public Order? Order { get; private set; } // public Order? Order { get; private set; }
/// <summary> /// <summary>