fergalmoran/chrometophone
1
0
Fork 0
mirror of https://github.com/fergalmoran/chrometophone.git synced 2025-12-30 13:39:57 +00:00
Code Issues 265 Packages Projects Releases Wiki Activity

Fix bug in unregistering old devices, if the oldest didn't include the id.

Browse Source
This commit is contained in:
costin
2010-12-08 23:46:49 +00:00
parent 28e3ed81f3
commit 6aff08cddc
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
appengine/src/com/google/android/chrometophone/server/RegisterServlet.java
View File

@@ -133,15 +133,19 @@ public class RegisterServlet extends HttpServlet {
// TODO: we should also define a 'ping' message and expire/remove // TODO: we should also define a 'ping' message and expire/remove
// unused registrations // unused registrations
DeviceInfo oldest = registrations.get(0); DeviceInfo oldest = registrations.get(0);
long oldestTime = oldest.getRegistrationTimestamp().getTime(); if (oldest.getRegistrationTimestamp() == null) {
for (int i = 1; i < registrations.size(); i++) { pm.deletePersistent(oldest);
if (registrations.get(i).getRegistrationTimestamp().getTime() < } else {
oldestTime) { long oldestTime = oldest.getRegistrationTimestamp().getTime();
oldest = registrations.get(i); for (int i = 1; i < registrations.size(); i++) {
oldestTime = oldest.getRegistrationTimestamp().getTime(); if (registrations.get(i).getRegistrationTimestamp().getTime() <
oldestTime) {
oldest = registrations.get(i);
oldestTime = oldest.getRegistrationTimestamp().getTime();
}
} }
pm.deletePersistent(oldest);
} }
pm.deletePersistent(oldest);
} }
// Get device if it already exists, else create // Get device if it already exists, else create