fergalmoran/flameshot
1
0
Fork 0
mirror of https://github.com/fergalmoran/flameshot.git synced 2025-12-22 09:51:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix English translations not used despite being preferred (#3822)

Browse Source 
When specifying the preferred language on Linux, the $LANGUAGE env var
is used. https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html

Example:
$ LANGUAGE=en:nl flameshot

Expected:
flameshot should be in English as this is a localization that flameshot provides.
If English would not be supported, it should fall back to using Dutch (nl).

Actual:
flameshot uses Dutch translations.

Cause:
If an empty translation file for "en" is not provided, English is only
used as a fallback.
See https://bugreports.qt.io/browse/QTBUG-69196
This commit is contained in:
Matthias Kunnen
2025-02-09 11:42:58 +01:00
committed by GitHub
parent 54644dff89
commit c35e16afcb
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
data/translations/Internationalization_en.ts Normal file
View File

@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<!--
An empty translation file is required for the base language, or it will only be used as a
fallback if the user prefers other supported languages. E.g.
$ LANGUAGE=en:nl flameshot
will result in Dutch translations being used despite English being higher priority.
See https://bugreports.qt.io/browse/QTBUG-69196
-->
<TS version="2.1" language="en">
</TS>

1
src/CMakeLists.txt
View File

@@ -103,6 +103,7 @@ set(FLAMESHOT_TS_FILES
${CMAKE_SOURCE_DIR}/data/translations/Internationalization_cs.ts ${CMAKE_SOURCE_DIR}/data/translations/Internationalization_cs.ts
${CMAKE_SOURCE_DIR}/data/translations/Internationalization_de_DE.ts ${CMAKE_SOURCE_DIR}/data/translations/Internationalization_de_DE.ts
${CMAKE_SOURCE_DIR}/data/translations/Internationalization_el.ts ${CMAKE_SOURCE_DIR}/data/translations/Internationalization_el.ts
${CMAKE_SOURCE_DIR}/data/translations/Internationalization_en.ts
${CMAKE_SOURCE_DIR}/data/translations/Internationalization_es.ts ${CMAKE_SOURCE_DIR}/data/translations/Internationalization_es.ts
${CMAKE_SOURCE_DIR}/data/translations/Internationalization_eu.ts ${CMAKE_SOURCE_DIR}/data/translations/Internationalization_eu.ts
${CMAKE_SOURCE_DIR}/data/translations/Internationalization_fa.ts ${CMAKE_SOURCE_DIR}/data/translations/Internationalization_fa.ts