Cppcheck and clazy warning fixes (#2821)

* Cppcheck and clazy warning fixes

* Clang-format

* Revert QRect call by value

* Revert QPoint call by value

* Revert complained renamings

---------

Co-authored-by: Haris Gušić <harisgusic.dev@gmail.com>
This commit is contained in:
El Thoro
2023-01-29 16:01:02 +01:00
committed by GitHub
parent 05c3b8746a
commit f7e41f4d70
39 changed files with 150 additions and 142 deletions

View File

@@ -384,8 +384,8 @@ void SelectionWidget::paintEvent(QPaintEvent*)
p.drawRect(rect() + QMargins(0, 0, -1, -1));
p.setRenderHint(QPainter::Antialiasing);
p.setBrush(m_color);
for (auto rect : handlerAreas()) {
p.drawEllipse(rect);
for (auto rectangle : handlerAreas()) {
p.drawEllipse(rectangle);
}
}
@@ -549,14 +549,14 @@ void SelectionWidget::updateCursor()
void SelectionWidget::setGeometryByKeyboard(const QRect& r)
{
static QTimer timer;
QRect rect = r.intersected(parentWidget()->rect());
if (rect.width() <= 0) {
rect.setWidth(1);
QRect rectangle = r.intersected(parentWidget()->rect());
if (rectangle.width() <= 0) {
rectangle.setWidth(1);
}
if (rect.height() <= 0) {
rect.setHeight(1);
if (rectangle.height() <= 0) {
rectangle.setHeight(1);
}
setGeometry(rect);
setGeometry(rectangle);
connect(&timer,
&QTimer::timeout,
this,