* Set x-kde-urls for notifications
The x-kde-urls field in the hints map allows us to provide a direct URL
to the saved screenshot. The notification server may then use this hint
to provide extra functionality, such as drag and drop support and
thumbnails.
For more information see https://community.kde.org/Plasma/Notifications#File_PathFixes#256
Note that other notification servers may ignore this hint.
* Avoid branching twice for ok
Current implementation of SystemNotification::sendMessage()
is wrongly using "flameshot.png" as icon name.
We should strip the suffix and directly use "flameshot" to comply
with Desktop Notification Specification.
This commit does so and indeed makes notifications show flameshot
icon on GNOME Shell again.
See also https://developer.gnome.org/notification-spec/ .
-use of the override keyword
-delete unused code
-const correctness
-more uniform code style
-for each with const references when possible
-getters no longer use the word 'get'
-others
