mirror of
https://github.com/fergalmoran/flameshot.git
synced 2026-02-12 05:24:01 +00:00
0f2ae9fab6
* flameshot.pro: Install SVG icon into $prefix/share/icons/hicolor/scalable/apps instead of $prefix/share/pixmaps While #293 somehow solves the icon problem, it is not the best solution. According to Freedesktop.org Icon Theme Specification (https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html): Directory Layout [...] By default, apps should look in $HOME/.icons (for backwards compatibility), in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order). [...] In order to have a place for third party applications to install their icons there should always exist a theme called "hicolor". While using /pixmaps/ directory ensures the least priority in search icons, the directory name itself "pixmaps" does not suite our actual situation (provided that "flameshot.svg" is a scalable icon, not a *pixmap*). I suggest that we place this icon into the "hicolor" theme (aka fallback theme) in /icons/ directory under "scalable/apps/" subdirectory. Proposed changes: 1. Install flameshot.svg under $prefix/share/icons/hicolor/scalable/apps/ instad of $prefix/share/pixmaps/ . 2. Rename qmake "icon" target into "appsvgicon" target so that the name "icon" may still be used in the future for other tasks. 3. The embedded rpm spec file is updated accordingly. Signed-off-by: Boyuan Yang <073plan@gmail.com> * img/app/flameshot.png: Use 128x128 size instead of 100x100 Converted using inkscape: inkscape -z -e flameshot.png -w 128 -h 128 flameshot.svg * img: Add hicolor subdir for installation under /usr/share/icons/hicolor/* * flameshot.pro: Use wildcard to install hicolor icon dir The embedded rpm spec file is updated too.