fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-03 23:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove SessionHistoryTraversalQueue::process()

Browse Source 
...because existance of this method conflicts with the purpose of
having a queue as it allows to start executing next task in the middle
of ongoing task.

For example:

1. SHTQ timer starts executing a task.
2. Task does SHTQ::process().

Another example:

1. SHTQ::process() start executing a task.
2. task does SHTQ::process().
This commit is contained in:
Aliaksandr Kalenik
2024-04-05 15:58:56 +02:00
committed by Alexander Kalenik
parent 11011cf250
commit 00531573a4
3 changed files with 0 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/Navigable.cpp
View File

@@ -1281,8 +1281,6 @@ WebIDL::ExceptionOr<void> Navigable::navigate(NavigateParams params)
// 1. Navigate to a fragment given navigable, url, historyHandling, userInvolvement, navigationAPIState, and navigationId.
TRY(navigate_to_a_fragment(url, to_history_handling_behavior(history_handling), user_involvement, navigation_api_state, navigation_id));
traversable_navigable()->process_session_history_traversal_queue();
// 2. Return.
return {};
}
@@ -1934,9 +1932,6 @@ void perform_url_and_history_update_steps(DOM::Document& document, URL::URL new_
// 1. Finalize a same-document navigation given traversable, navigable, newEntry, and entryToReplace.
finalize_a_same_document_navigation(*traversable, *navigable, new_entry, entry_to_replace, history_handling);
});
// FIXME: Implement synchronous session history steps.
traversable->process_session_history_traversal_queue();
}
void Navigable::scroll_offset_did_change()