From 0321d1392cb339f9c5cfa2c92c04bb8c9300fc8c Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Tue, 21 Jan 2025 16:15:58 +0000 Subject: [PATCH] LibWeb/CSS: Leave calc() in transformations unresolved for longer We don't need to resolve these at this point, and we already don't do so for lengths, so leave them in their calc() form until they're used. --- .../LibWeb/CSS/StyleValues/TransformationStyleValue.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Libraries/LibWeb/CSS/StyleValues/TransformationStyleValue.cpp b/Libraries/LibWeb/CSS/StyleValues/TransformationStyleValue.cpp index 9ee475ebb5..37694b99b8 100644 --- a/Libraries/LibWeb/CSS/StyleValues/TransformationStyleValue.cpp +++ b/Libraries/LibWeb/CSS/StyleValues/TransformationStyleValue.cpp @@ -31,14 +31,14 @@ Transformation TransformationStyleValue::to_transformation() const } else if (calculated.resolves_to_percentage()) { // FIXME: Maybe transform this for loop to always check the metadata for the correct types if (function_metadata.parameters[argument_index].type == TransformFunctionParameterType::NumberPercentage) { - values.append(NumberPercentage { calculated.resolve_percentage().value() }); + values.append(NumberPercentage { calculated }); } else { - values.append(LengthPercentage { calculated.resolve_percentage().value() }); + values.append(LengthPercentage { calculated }); } } else if (calculated.resolves_to_number()) { - values.append({ Number(Number::Type::Number, calculated.resolve_number().value()) }); + values.append(NumberPercentage { calculated }); } else if (calculated.resolves_to_angle()) { - values.append({ calculated.resolve_angle().value() }); + values.append(AngleOrCalculated { calculated }); } else { dbgln("FIXME: Unsupported calc value in transform! {}", calculated.to_string(SerializationMode::Normal)); }