From 0b2c80e503cb36888cb071533a6c74d0e6be0870 Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Wed, 1 Jan 2025 16:20:56 +1300 Subject: [PATCH] LibJS: Adjust FIXME for an incorrect assertion in GetModuleNamespace It turns out that the FIXME which we had left unimplemented is actually a spec bug. --- Libraries/LibJS/Module.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/LibJS/Module.cpp b/Libraries/LibJS/Module.cpp index 2f2d238f8f..6f566e21a6 100644 --- a/Libraries/LibJS/Module.cpp +++ b/Libraries/LibJS/Module.cpp @@ -123,7 +123,7 @@ void finish_loading_imported_module(ImportedModuleReferrer referrer, ModuleReque ThrowCompletionOr Module::get_module_namespace(VM& vm) { // 1. Assert: If module is a Cyclic Module Record, then module.[[Status]] is not unlinked. - // FIXME: How do we check this without breaking encapsulation? + // FIXME: Spec bug: https://github.com/tc39/ecma262/issues/3114 // 2. Let namespace be module.[[Namespace]]. auto* namespace_ = m_namespace.ptr();