fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-28 12:18:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't allow "display: none" start CSS animations

Browse Source 
This is both a correctness fix and a performance optimization.
This commit is contained in:
Aliaksandr Kalenik
2025-01-31 22:26:59 +01:00
committed by Alexander Kalenik
parent 93f9ed72d2
commit 0cfe90b59e
6 changed files with 116 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/CSS/StyleComputer.cpp
View File

@@ -2502,8 +2502,10 @@ GC::Ref<ComputedProperties> StyleComputer::compute_properties(DOM::Element& elem
effect->set_target(&element);
element.set_cached_animation_name_animation(animation, pseudo_element);
HTML::TemporaryExecutionContext context(realm);
animation->play().release_value_but_fixme_should_propagate_errors();
if (!element.has_display_none_ancestor()) {
HTML::TemporaryExecutionContext context(realm);
animation->play().release_value_but_fixme_should_propagate_errors();
}
} else {
// The animation hasn't changed, but some properties of the animation may have
if (auto animation = element.cached_animation_name_animation(pseudo_element); animation)