fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-27 11:48:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibDevTools+LibWebView: Avoid dependence on LibWebView from LibDevTools

Browse Source 
LibDevTools was implicitly including generated IPC endpoints from
LibWebView. This is not a dependency declared in the CMakeLists.txt. So
updates to the IPC file might not have caused the endpoint header to be
regenerated by the time LibDevTools is compiled, resulting in a build
error.

This patch removes that implicit dependency entirely.
This commit is contained in:
Timothy Flynn
2025-02-26 17:23:10 -05:00
committed by Tim Flynn
parent 8ab61843be
commit 0d1ce48071
4 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWebView/Application.cpp
View File

@@ -389,7 +389,11 @@ void Application::inspect_dom_node(DevTools::TabDescription const& description,
view->on_received_dom_node_properties = [&view = *view, on_complete = move(on_complete)](ViewImplementation::DOMNodeProperties properties) {
view.on_received_dom_node_properties = nullptr;
on_complete(move(properties));
on_complete(DevTools::DOMNodeProperties {
.computed_style = move(properties.computed_style),
.node_box_sizing = move(properties.node_box_sizing),
});
};
view->inspect_dom_node(node_id, pseudo_element);