fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-26 19:29:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Plumb the full HtmlView viewport rect down into the engine

Browse Source 
Previously we would use the "content rect" as the viewport rect, which
could sometimes be smaller than the actual viewport rect as the content
size was based on the box geometry of the root layout node.

This fixes an issue on google.com where we would not render the main
logo image since it was "outside" the viewport. The root layout size
is currently very wrong on google.com but that's a separate issue. :^)
This commit is contained in:
Andreas Kling
2020-05-04 22:35:29 +02:00
parent d3de2b7de5
commit 0d2beddc74
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/HtmlView.cpp
View File

@@ -124,7 +124,7 @@ void HtmlView::layout_and_sync_size()
set_content_size(enclosing_int_rect(layout_root()->rect()).size());
}
main_frame().set_viewport_rect(visible_content_rect());
main_frame().set_viewport_rect(viewport_rect_in_content_coordinates());
#ifdef HTML_DEBUG
dbgprintf("\033[33;1mLayout tree after layout:\033[0m\n");
@@ -162,7 +162,7 @@ void HtmlView::paint_event(GUI::PaintEvent& event)
RenderingContext context(painter, palette());
context.set_should_show_line_box_borders(m_should_show_line_box_borders);
context.set_viewport_rect(visible_content_rect());
context.set_viewport_rect(viewport_rect_in_content_coordinates());
layout_root()->render(context);
}
@@ -518,7 +518,7 @@ void HtmlView::dump_selection(const char* event_name)
void HtmlView::did_scroll()
{
main_frame().set_viewport_rect(visible_content_rect());
main_frame().set_viewport_rect(viewport_rect_in_content_coordinates());
}
Gfx::Point HtmlView::compute_mouse_event_offset(const Gfx::Point& event_position, const LayoutNode& layout_node) const