fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-04 15:45:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add basic support for position:fixed

Browse Source 
Fixed position elements have the ICB as their containing block.
The magic of fixed positioning is implemented at the rendering stage,
where we temporarily translate painting by the current scroll offset.

Note that "absolutely positioned" includes both position:absolute
and position:fixed.
This commit is contained in:
Andreas Kling
2020-06-12 14:19:03 +02:00
parent bd33bfd120
commit 137f6d44ec
8 changed files with 27 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Libraries/LibWeb/Layout/LayoutBlock.cpp
View File

@@ -29,6 +29,7 @@
#include <LibWeb/DOM/Element.h>
#include <LibWeb/Dump.h>
#include <LibWeb/Layout/LayoutBlock.h>
#include <LibWeb/Layout/LayoutDocument.h>
#include <LibWeb/Layout/LayoutInline.h>
#include <LibWeb/Layout/LayoutReplaced.h>
#include <LibWeb/Layout/LayoutText.h>
@@ -67,10 +68,10 @@ void LayoutBlock::layout(LayoutMode layout_mode)
compute_height();
if (layout_mode == LayoutMode::Default)
layout_absolute_descendants();
layout_absolutely_positioned_descendants();
}
void LayoutBlock::layout_absolute_descendants()
void LayoutBlock::layout_absolutely_positioned_descendants()
{
for (auto& box : m_absolutely_positioned_descendants) {
box->layout(LayoutMode::Default);
@@ -441,9 +442,7 @@ void LayoutBlock::compute_width()
void LayoutBlock::compute_position()
{
// Absolutely positioned blocks are positioned by position_absolute_boxes()
if (is_absolutely_positioned()) {
dbg() << "Is abspos, adding to containing block " << containing_block()->node()->tag_name();
const_cast<LayoutBlock*>(containing_block())->add_absolutely_positioned_descendant(*this);
return;
}