fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 00:25:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Port CSSNamespaceRule to FlyString

Browse Source 
This removes a performance problem where we'd convert the style sheet's
default namespace from DeprecatedFlyString to FlyString once per rule
during selector matching.

The conversion now happens once, during CSS parse. It should eventually
be removed from there as well, but one step at a time. :^)
This commit is contained in:
Andreas Kling
2023-12-01 13:36:40 +01:00
parent d8f84ef76c
commit 189d1e8291
4 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibWeb/CSS/CSSStyleSheet.cpp
View File

@@ -149,7 +149,7 @@ void CSSStyleSheet::set_style_sheet_list(Badge<StyleSheetList>, StyleSheetList*
Optional<FlyString> CSSStyleSheet::default_namespace() const
{
if (m_default_namespace_rule)
return MUST(FlyString::from_deprecated_fly_string(m_default_namespace_rule->namespace_uri()));
return m_default_namespace_rule->namespace_uri();
return {};
}
@@ -158,7 +158,7 @@ Optional<FlyString> CSSStyleSheet::namespace_uri(StringView namespace_prefix) co
{
return m_namespace_rules.get(namespace_prefix)
.map([](JS::GCPtr<CSSNamespaceRule> namespace_) {
return MUST(FlyString::from_deprecated_fly_string(namespace_->namespace_uri()));
return namespace_->namespace_uri();
});
}
@@ -189,7 +189,7 @@ void CSSStyleSheet::recalculate_namespaces()
if (!namespace_rule.namespace_uri().is_empty() && namespace_rule.prefix().is_empty())
m_default_namespace_rule = namespace_rule;
m_namespace_rules.set(FlyString::from_deprecated_fly_string(namespace_rule.prefix()).release_value_but_fixme_should_propagate_errors(), namespace_rule);
m_namespace_rules.set(namespace_rule.prefix(), namespace_rule);
}
}