fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Refactor "editable" and "editing host" concepts

Browse Source 
The DOM spec defines what it means for an element to be an "editing
host", and the Editing spec does the same for the "editable" concept.
Replace our `Node::is_editable()` implementation with these
spec-compliant algorithms.

An editing host is an element that has the properties to make its
contents effectively editable. Editable elements are descendants of an
editing host. Concepts like the inheritable contenteditable attribute
are propagated through the editable algorithm.
This commit is contained in:
Jelle Raaijmakers
2024-12-06 11:41:20 +01:00
committed by Jelle Raaijmakers
parent f88c13a58c
commit 1c55153d43
22 changed files with 85 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Libraries/LibWeb/Painting/PaintableBox.cpp
View File

@@ -564,7 +564,12 @@ void paint_cursor_if_needed(PaintContext& context, TextPaintable const& paintabl
if (cursor_position->offset() < (unsigned)fragment.start() || cursor_position->offset() > (unsigned)(fragment.start() + fragment.length()))
return;
if (!fragment.layout_node().dom_node() || !fragment.layout_node().dom_node()->is_editable())
auto active_element = document.active_element();
auto active_element_is_editable = is<HTML::FormAssociatedTextControlElement>(active_element)
&& dynamic_cast<HTML::FormAssociatedTextControlElement const&>(*active_element).is_mutable();
auto dom_node = fragment.layout_node().dom_node();
if (!dom_node || (!dom_node->is_editable() && !active_element_is_editable))
return;
auto fragment_rect = fragment.absolute_rect();