fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Port Document encoding_parse_url and parse_url to Optional<URL>

Browse Source 
This ports two more APIs away from URL::is_valid.
This commit is contained in:
Shannon Booth
2025-01-23 19:40:57 +13:00
committed by Tim Ledbetter
parent cfe9b7a82b
commit 22a7cd9700
26 changed files with 135 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
Libraries/LibWeb/HTML/HTMLLinkElement.cpp
View File

@@ -77,18 +77,25 @@ void HTMLLinkElement::inserted()
// FIXME: Follow spec for fetching and processing these attributes as well
if (m_relationship & Relationship::Preload) {
// FIXME: Respect the "as" attribute.
LoadRequest request;
request.set_url(document().encoding_parse_url(get_attribute_value(HTML::AttributeNames::href)));
set_resource(ResourceLoader::the().load_resource(Resource::Type::Generic, request));
if (auto maybe_href = document().encoding_parse_url(get_attribute_value(HTML::AttributeNames::href)); maybe_href.has_value()) {
// FIXME: Respect the "as" attribute.
LoadRequest request;
request.set_url(maybe_href.value());
set_resource(ResourceLoader::the().load_resource(Resource::Type::Generic, request));
}
} else if (m_relationship & Relationship::DNSPrefetch) {
ResourceLoader::the().prefetch_dns(document().encoding_parse_url(get_attribute_value(HTML::AttributeNames::href)));
if (auto dns_prefetch_url = document().encoding_parse_url(get_attribute_value(HTML::AttributeNames::href)); dns_prefetch_url.has_value()) {
ResourceLoader::the().prefetch_dns(dns_prefetch_url.value());
}
} else if (m_relationship & Relationship::Preconnect) {
ResourceLoader::the().preconnect(document().encoding_parse_url(get_attribute_value(HTML::AttributeNames::href)));
if (auto maybe_href = document().encoding_parse_url(get_attribute_value(HTML::AttributeNames::href)); maybe_href.has_value()) {
ResourceLoader::the().preconnect(maybe_href.value());
}
} else if (m_relationship & Relationship::Icon) {
auto favicon_url = document().encoding_parse_url(href());
auto favicon_request = LoadRequest::create_for_url_on_page(favicon_url, &document().page());
set_resource(ResourceLoader::the().load_resource(Resource::Type::Generic, favicon_request));
if (auto favicon_url = document().encoding_parse_url(href()); favicon_url.has_value()) {
auto favicon_request = LoadRequest::create_for_url_on_page(favicon_url.value(), &document().page());
set_resource(ResourceLoader::the().load_resource(Resource::Type::Generic, favicon_request));
}
}
}
@@ -572,7 +579,7 @@ WebIDL::ExceptionOr<void> HTMLLinkElement::load_fallback_favicon_if_needed(GC::R
// synchronous flag is set, credentials mode is "include", and whose use-URL-credentials flag is set.
// NOTE: Fetch requests no longer have a synchronous flag, see https://github.com/whatwg/fetch/pull/1165
auto request = Fetch::Infrastructure::Request::create(vm);
request->set_url(document->parse_url("/favicon.ico"sv));
request->set_url(*document->parse_url("/favicon.ico"sv));
request->set_client(&document->relevant_settings_object());
request->set_destination(Fetch::Infrastructure::Request::Destination::Image);
request->set_credentials_mode(Fetch::Infrastructure::Request::CredentialsMode::Include);