fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibMedia+everywhere: Remove superfluous and unused audio code

Browse Source 
We had numerous NiH-based implementations of audio formats and metadata
that we now no longer need because we either don't make use of the code,
or we replaced its implementation by FFmpeg.
This commit is contained in:
Jelle Raaijmakers
2024-09-30 14:49:59 +02:00
committed by Andreas Kling
parent 57783eff24
commit 233b4f2ca8
46 changed files with 12 additions and 6530 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Meta/CMake/all_the_debug_macros.cmake
View File

@@ -1,6 +1,4 @@
set(AUDIO_DEBUG ON)
set(AWAVLOADER_DEBUG ON)
set(AFLACLOADER_DEBUG ON)
set(BMP_DEBUG ON)
set(CACHE_DEBUG ON)
set(CALLBACK_MACHINE_DEBUG ON)

14
Meta/Lagom/Fuzzers/FuzzFlacLoader.cpp
View File

@@ -1,14 +0,0 @@
/*
* Copyright (c) 2023, kleines Filmröllchen <filmroellchen@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "AudioFuzzerCommon.h"
#include <LibMedia/Audio/FlacLoader.h>
extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
{
AK::set_debug_enabled(false);
return fuzz_audio_loader<Audio::FlacLoaderPlugin>(data, size);
}

14
Meta/Lagom/Fuzzers/FuzzMP3Loader.cpp
View File

@@ -1,14 +0,0 @@
/*
* Copyright (c) 2023, kleines Filmröllchen <filmroellchen@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "AudioFuzzerCommon.h"
#include <LibMedia/Audio/MP3Loader.h>
extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
{
AK::set_debug_enabled(false);
return fuzz_audio_loader<Audio::MP3LoaderPlugin>(data, size);
}

14
Meta/Lagom/Fuzzers/FuzzQOALoader.cpp
View File

@@ -1,14 +0,0 @@
/*
* Copyright (c) 2023, kleines Filmröllchen <filmroellchen@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "AudioFuzzerCommon.h"
#include <LibMedia/Audio/QOALoader.h>
extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
{
AK::set_debug_enabled(false);
return fuzz_audio_loader<Audio::QOALoaderPlugin>(data, size);
}

14
Meta/Lagom/Fuzzers/FuzzWAVLoader.cpp
View File

@@ -1,14 +0,0 @@
/*
* Copyright (c) 2023, kleines Filmröllchen <filmroellchen@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "AudioFuzzerCommon.h"
#include <LibMedia/Audio/WavLoader.h>
extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
{
AK::set_debug_enabled(false);
return fuzz_audio_loader<Audio::WavLoaderPlugin>(data, size);
}

8
Meta/Lagom/Fuzzers/fuzzers.cmake
View File

@@ -6,7 +6,6 @@ set(FUZZER_TARGETS
Brotli
DeflateCompression
DeflateDecompression
FlacLoader
GIFLoader
GzipDecompression
GzipRoundtrip
@@ -19,11 +18,9 @@ set(FUZZER_TARGETS
LzmaRoundtrip
MatroskaReader
MD5
MP3Loader
PEM
PNGLoader
Poly1305
QOALoader
RegexECMA262
RegexPosixBasic
RegexPosixExtended
@@ -38,7 +35,6 @@ set(FUZZER_TARGETS
TinyVGLoader
URL
WasmParser
WAVLoader
WebPLoader
WOFF
WOFF2
@@ -59,7 +55,6 @@ set(FUZZER_DEPENDENCIES_CSSParser LibWeb)
set(FUZZER_DEPENDENCIES_DeflateCompression LibCompress)
set(FUZZER_DEPENDENCIES_DeflateDecompression LibCompress)
set(FUZZER_DEPENDENCIES_ELF LibELF)
set(FUZZER_DEPENDENCIES_FlacLoader LibMedia)
set(FUZZER_DEPENDENCIES_GIFLoader LibGfx)
set(FUZZER_DEPENDENCIES_GzipDecompression LibCompress)
set(FUZZER_DEPENDENCIES_GzipRoundtrip LibCompress)
@@ -71,11 +66,9 @@ set(FUZZER_DEPENDENCIES_LzmaDecompression LibArchive LibCompress)
set(FUZZER_DEPENDENCIES_LzmaRoundtrip LibCompress)
set(FUZZER_DEPENDENCIES_MatroskaReader LibMedia)
set(FUZZER_DEPENDENCIES_MD5 LibCrypto)
set(FUZZER_DEPENDENCIES_MP3Loader LibMedia)
set(FUZZER_DEPENDENCIES_PEM LibCrypto)
set(FUZZER_DEPENDENCIES_PNGLoader LibGfx)
set(FUZZER_DEPENDENCIES_Poly1305 LibCrypto)
set(FUZZER_DEPENDENCIES_QOALoader LibMedia)
set(FUZZER_DEPENDENCIES_RegexECMA262 LibRegex)
set(FUZZER_DEPENDENCIES_RegexPosixBasic LibRegex)
set(FUZZER_DEPENDENCIES_RegexPosixExtended LibRegex)
@@ -91,7 +84,6 @@ set(FUZZER_DEPENDENCIES_TTF LibGfx)
set(FUZZER_DEPENDENCIES_TinyVGLoader LibGfx)
set(FUZZER_DEPENDENCIES_URL LibURL)
set(FUZZER_DEPENDENCIES_WasmParser LibWasm)
set(FUZZER_DEPENDENCIES_WAVLoader LibMedia)
set(FUZZER_DEPENDENCIES_WebPLoader LibGfx)
set(FUZZER_DEPENDENCIES_WOFF LibGfx)
set(FUZZER_DEPENDENCIES_WOFF2 LibGfx)

2
Meta/gn/secondary/AK/BUILD.gn
View File

@@ -220,8 +220,6 @@ write_cmake_config("ak_debug_gen") {
output = "$root_gen_dir/AK/Debug.h"
values = [
"AUDIO_DEBUG=",
"AWAVLOADER_DEBUG=",
"AFLACLOADER_DEBUG=",
"BINDINGS_GENERATOR_DEBUG=",
"BMP_DEBUG=",
"CACHE_DEBUG=",

8
Meta/gn/secondary/Userland/Libraries/LibMedia/BUILD.gn
View File

@@ -4,17 +4,9 @@ import("//Meta/gn/build/libs/pulse/enable.gni")
shared_library("LibMedia") {
include_dirs = [ "//Userland/Libraries" ]
sources = [
"Audio/FlacLoader.cpp",
"Audio/GenericTypes.cpp",
"Audio/Loader.cpp",
"Audio/MP3Loader.cpp",
"Audio/Metadata.cpp",
"Audio/PlaybackStream.cpp",
"Audio/QOALoader.cpp",
"Audio/QOATypes.cpp",
"Audio/SampleFormats.cpp",
"Audio/VorbisComment.cpp",
"Audio/WavLoader.cpp",
"Color/ColorConverter.cpp",
"Color/ColorPrimaries.cpp",
"Color/TransferCharacteristics.cpp",