fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

WebContent: Annotate unexpected alert open errors for WebDriver

Browse Source 
This was missed in commit 2583996e18.
WPT recently began testing for this.
This commit is contained in:
Timothy Flynn
2025-02-16 12:38:54 -05:00
committed by Andreas Kling
parent 29d74632c7
commit 23a8bbca01
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Services/WebContent/WebDriverConnection.cpp
View File

@@ -2669,6 +2669,22 @@ Web::WebDriver::PromptHandlerConfiguration WebDriverConnection::get_the_prompt_h
return { .handler = Web::WebDriver::PromptHandler::Dismiss, .notify = Web::WebDriver::PromptHandlerConfiguration::Notify::Yes }; return { .handler = Web::WebDriver::PromptHandler::Dismiss, .notify = Web::WebDriver::PromptHandlerConfiguration::Notify::Yes };
} }
// https://w3c.github.io/webdriver/#dfn-annotated-unexpected-alert-open-error
static Web::WebDriver::Error create_annotated_unexpected_alert_open_error(Optional<String> const& text)
{
// An annotated unexpected alert open error is an error with error code unexpected alert open and an optional error
// data dictionary with the following entries:
// "text"
// The current user prompt's message.
auto data = text.map([&](auto const& text) -> JsonValue {
JsonObject data;
data.set("text"sv, text.to_byte_string());
return data;
});
return Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::UnexpectedAlertOpen, "A user prompt is open"sv, move(data));
}
// https://w3c.github.io/webdriver/#dfn-handle-any-user-prompts // https://w3c.github.io/webdriver/#dfn-handle-any-user-prompts
void WebDriverConnection::handle_any_user_prompts(Function<void()> on_dialog_closed) void WebDriverConnection::handle_any_user_prompts(Function<void()> on_dialog_closed)
{ {
@@ -2705,10 +2721,10 @@ void WebDriverConnection::handle_any_user_prompts(Function<void()> on_dialog_clo
// 3. Let handler be get the prompt handler with type. // 3. Let handler be get the prompt handler with type.
auto handler = get_the_prompt_handler(type); auto handler = get_the_prompt_handler(type);
auto on_complete = GC::create_function(heap, [this, notify = handler.notify, on_dialog_closed = GC::create_function(heap, move(on_dialog_closed))]() { auto on_complete = GC::create_function(heap, [this, notify = handler.notify, pending_dialog_text = page.pending_dialog_text(), on_dialog_closed = GC::create_function(heap, move(on_dialog_closed))]() {
// 5. If handler's notify is true, return annotated unexpected alert open error. // 5. If handler's notify is true, return annotated unexpected alert open error.
if (notify == Web::WebDriver::PromptHandlerConfiguration::Notify::Yes) { if (notify == Web::WebDriver::PromptHandlerConfiguration::Notify::Yes) {
async_driver_execution_complete(Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::UnexpectedAlertOpen, "A user prompt is open"sv)); async_driver_execution_complete(create_annotated_unexpected_alert_open_error(pending_dialog_text));
return; return;
} }