fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-04 07:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't proceed with Element.click() on disabled form controls

Browse Source 
Fixes an infinite reload loop on some of the dom/events/ tests in WPT.
This commit is contained in:
Andreas Kling
2024-07-26 10:31:19 +02:00
committed by Andreas Kling
parent 696ccc1aa9
commit 273593afba
3 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/HTMLElement.cpp
View File

@@ -496,7 +496,11 @@ JS::GCPtr<DOM::NodeList> HTMLElement::labels()
// https://html.spec.whatwg.org/multipage/interaction.html#dom-click
void HTMLElement::click()
{
// FIXME: 1. If this element is a form control that is disabled, then return.
// 1. If this element is a form control that is disabled, then return.
if (auto* form_control = dynamic_cast<FormAssociatedElement*>(this)) {
if (!form_control->enabled())
return;
}
// 2. If this element's click in progress flag is set, then return.
if (m_click_in_progress)