fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-24 02:09:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

AK+Everywhere: Remove now-unecessary use of ByteString with JSON types

Browse Source 
This removes JsonObject::get_byte_string and JsonObject::to_byte_string.
This commit is contained in:
Timothy Flynn
2025-02-17 15:04:56 -05:00
committed by Tim Flynn
parent 4791ec35bf
commit 2c03de60da
17 changed files with 67 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Libraries/LibTest/JavaScriptTestRunner.h
View File

@@ -376,12 +376,12 @@ inline JSFileResult TestRunner::run_file_test(ByteString const& test_path)
VERIFY(suite_value.is_object());
suite_value.as_object().for_each_member([&](String const& test_name, JsonValue const& test_value) {
Test::Case test { test_name, Test::Result::Fail, "", 0 };
Test::Case test { test_name, Test::Result::Fail, {}, 0 };
VERIFY(test_value.is_object());
VERIFY(test_value.as_object().has("result"sv));
auto result = test_value.as_object().get_byte_string("result"sv);
auto result = test_value.as_object().get_string("result"sv);
VERIFY(result.has_value());
auto result_string = result.value();
if (result_string == "pass") {
@@ -392,9 +392,9 @@ inline JSFileResult TestRunner::run_file_test(ByteString const& test_path)
m_counts.tests_failed++;
suite.most_severe_test_result = Test::Result::Fail;
VERIFY(test_value.as_object().has("details"sv));
auto details = test_value.as_object().get_byte_string("details"sv);
auto details = test_value.as_object().get_string("details"sv);
VERIFY(result.has_value());
test.details = details.value();
test.details = details.release_value();
} else if (result_string == "xfail") {
test.result = Test::Result::ExpectedFail;
m_counts.tests_expected_failed++;
@@ -430,7 +430,7 @@ inline JSFileResult TestRunner::run_file_test(ByteString const& test_path)
Test::Suite suite { test_path, "<top-level>"_string };
suite.most_severe_test_result = Result::Crashed;
Test::Case test_case { "<top-level>"_string, Test::Result::Fail, "", 0 };
Test::Case test_case { "<top-level>"_string, Test::Result::Fail, {}, 0 };
auto error = top_level_result.release_error().release_value().release_value();
if (error.is_object()) {
StringBuilder detail_builder;
@@ -453,9 +453,9 @@ inline JSFileResult TestRunner::run_file_test(ByteString const& test_path)
detail_builder.append(error_as_error.stack_string());
}
test_case.details = detail_builder.to_byte_string();
test_case.details = MUST(detail_builder.to_string());
} else {
test_case.details = error.to_string_without_side_effects().to_byte_string();
test_case.details = error.to_string_without_side_effects();
}
suite.tests.append(move(test_case));