fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-26 03:09:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Throw error in Object::to_string() if string conversion fails

Browse Source
This commit is contained in:
Linus Groh
2020-04-29 16:29:26 +01:00
committed by Andreas Kling
parent 95abcc3722
commit 2c6e7dbd07
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Libraries/LibJS/Runtime/Object.cpp
View File

@@ -360,7 +360,13 @@ Value Object::to_string() const
&& to_string_property.is_object()
&& to_string_property.as_object().is_function()) {
auto& to_string_function = static_cast<Function&>(to_string_property.as_object());
return const_cast<Object*>(this)->interpreter().call(to_string_function, const_cast<Object*>(this));
auto& interpreter = const_cast<Object*>(this)->interpreter();
auto string_value = interpreter.call(to_string_function, const_cast<Object*>(this));
if (!string_value.is_string())
interpreter.throw_exception<TypeError>("Cannot convert object to string");
if (interpreter.exception())
return {};
return string_value;
}
return js_string(heap(), String::format("[object %s]", class_name()));
}