fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-30 13:19:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Avoid crash from zero-duration transitions

Browse Source
This commit is contained in:
Gingeh
2025-01-08 14:37:03 +11:00
committed by Sam Atkins
parent 8e56109515
commit 2cac0dc20c
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibWeb/CSS/CSSTransition.cpp
View File

@@ -140,6 +140,11 @@ void CSSTransition::visit_edges(Cell::Visitor& visitor)
double CSSTransition::timing_function_output_at_time(double t) const
{
auto progress = (t - transition_start_time()) / (transition_end_time() - transition_start_time());
// AD-HOC: If the transition has an empty duration then we get NaN here,
// setting progress to 1 because an instant transition may be considered "finished".
if (transition_start_time() < transition_end_time())
progress = 1;
// FIXME: Is this before_flag value correct?
bool before_flag = t < transition_start_time();
return m_keyframe_effect->timing_function().evaluate_at(progress, before_flag);