Meta: Add a --debug-process option to WPT.sh

This passes the `--debug-process` option to WebDriver.
This commit is contained in:
Tim Ledbetter
2024-12-12 11:47:39 +00:00
committed by Jelle Raaijmakers
parent 2528055703
commit 34f78ca152
2 changed files with 8 additions and 2 deletions

View File

@@ -72,6 +72,8 @@ print_help() {
Run the Web Platform Tests in the 'css' and 'dom' directories and save the output to expectations.log. Run the Web Platform Tests in the 'css' and 'dom' directories and save the output to expectations.log.
$NAME run --log-wptreport expectations.json --log-wptscreenshot expectations.db css dom $NAME run --log-wptreport expectations.json --log-wptscreenshot expectations.db css dom
Run the Web Platform Tests in the 'css' and 'dom' directories; save the output in wptreport format to expectations.json and save screenshots to expectations.db. Run the Web Platform Tests in the 'css' and 'dom' directories; save the output in wptreport format to expectations.json and save screenshots to expectations.db.
$NAME run --debug-process WebContent http://wpt.live/dom/historical.html
Run the 'dom/historical.html' test, attaching the debugger to the WebContent process when the browser is launched.
$NAME compare expectations.log $NAME compare expectations.log
Run all of the Web Platform Tests comparing the results to the expectations in before.log. Run all of the Web Platform Tests comparing the results to the expectations in before.log.
$NAME compare --log results.log expectations.log css/CSS2 $NAME compare --log results.log expectations.log css/CSS2
@@ -109,11 +111,16 @@ set_logging_flags()
headless=1 headless=1
ARG=$1 ARG=$1
while [[ "$ARG" =~ ^(--show-window|(--log(-(raw|unittest|xunit|html|mach|tbpl|grouped|chromium|wptreport|wptscreenshot))?))$ ]]; do while [[ "$ARG" =~ ^(--show-window|--debug-process|(--log(-(raw|unittest|xunit|html|mach|tbpl|grouped|chromium|wptreport|wptscreenshot))?))$ ]]; do
case "$ARG" in case "$ARG" in
--show-window) --show-window)
headless=0 headless=0
;; ;;
--debug-process)
process_name="${2}"
shift
WPT_ARGS+=( "--webdriver-arg=--debug-process=${process_name}" )
;;
--log) --log)
set_logging_flags "--log-raw" "${2}" set_logging_flags "--log-raw" "${2}"
shift shift

View File

@@ -52,7 +52,6 @@ static Vector<ByteString> create_arguments(ByteString const& socket_path, bool f
if (force_cpu_painting) if (force_cpu_painting)
arguments.append("--force-cpu-painting"sv); arguments.append("--force-cpu-painting"sv);
dbgln("Debug process: {}", debug_process);
if (debug_process.has_value()) if (debug_process.has_value())
arguments.append(ByteString::formatted("--debug-process={}", debug_process.value())); arguments.append(ByteString::formatted("--debug-process={}", debug_process.value()));