fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-01 06:07:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Convert CanonicalNumericIndexString to use NumberToString

Browse Source
This commit is contained in:
Timothy Flynn
2023-02-12 21:38:17 -05:00
committed by Linus Groh
parent 9a5a4302d9
commit 36d72a7f4c
5 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp
View File

@@ -1169,7 +1169,7 @@ Object* create_mapped_arguments_object(VM& vm, FunctionObject& function, Vector<
}
// 7.1.21 CanonicalNumericIndexString ( argument ), https://tc39.es/ecma262/#sec-canonicalnumericindexstring
CanonicalIndex canonical_numeric_index_string(PropertyKey const& property_key, CanonicalIndexMode mode)
ThrowCompletionOr<CanonicalIndex> canonical_numeric_index_string(VM& vm, PropertyKey const& property_key, CanonicalIndexMode mode)
{
// NOTE: If the property name is a number type (An implementation-defined optimized
// property key type), it can be treated as a string property that has already been
@@ -1219,11 +1219,10 @@ CanonicalIndex canonical_numeric_index_string(PropertyKey const& property_key, C
auto maybe_double = argument.to_double(AK::TrimWhitespace::No);
if (!maybe_double.has_value())
return CanonicalIndex(CanonicalIndex::Type::Undefined, 0);
auto double_value = Value(maybe_double.value());
// FIXME: We return 0 instead of n but it might not observable?
// 3. If SameValue(! ToString(n), argument) is true, return n.
if (double_value.to_deprecated_string_without_side_effects() == argument)
if (TRY_OR_THROW_OOM(vm, number_to_string(*maybe_double)) == argument.view())
return CanonicalIndex(CanonicalIndex::Type::Numeric, 0);
// 4. Return undefined.