fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-03 15:16:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Stop invoking UB in AK::NeverDestroyed's tests

Browse Source 
Instead of attempting a stack use-after-free by reading an out-of-scope
object's data member, let's keep a flag that checks if the destructor
had been called in the outer scope.

Fixes #64
This commit is contained in:
Daniel Bertalan
2024-06-05 23:52:33 +02:00
committed by Andrew Kaster
parent 8641e78cdc
commit 376b956214
1 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
Tests/AK/TestNeverDestroyed.cpp
View File

@@ -44,20 +44,27 @@ TEST_CASE(should_construct_by_move)
EXPECT_EQ(1, n->num_moves); EXPECT_EQ(1, n->num_moves);
} }
NO_SANITIZE_ADDRESS static void should_not_destroy() struct DestructorChecker {
{ DestructorChecker(bool& destroyed)
Counter* c = nullptr; : m_destroyed(destroyed)
{ {
AK::NeverDestroyed<Counter> n {};
// note: explicit stack-use-after-scope
c = &n.get();
} }
EXPECT_EQ(0, c->num_destroys);
} ~DestructorChecker()
{
m_destroyed = true;
}
bool& m_destroyed;
};
TEST_CASE(should_not_destroy) TEST_CASE(should_not_destroy)
{ {
should_not_destroy(); bool destroyed = false;
{
AK::NeverDestroyed<DestructorChecker> n(destroyed);
}
EXPECT(!destroyed);
} }
TEST_CASE(should_provide_dereference_operator) TEST_CASE(should_provide_dereference_operator)