fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-02 22:55:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

RequestServer: Remove IPV6 bracket notation on host before resolving

Browse Source 
Previously, we were passing in the serialized value which included
square brackets but that isn't a valid IPV6 address.
This commit is contained in:
rmg-x
2025-02-16 16:18:39 -06:00
committed by Ali Mohammad Pur
parent 23a8bbca01
commit 41c6f93aa8
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Services/RequestServer/ConnectionFromClient.cpp
View File

@@ -353,6 +353,11 @@ void ConnectionFromClient::start_request(i32 request_id, ByteString const& metho
} }
auto host = url.serialized_host().to_byte_string(); auto host = url.serialized_host().to_byte_string();
// Check if host has the bracket notation for IPV6 addresses and remove them
if (host.starts_with("["sv) && host.ends_with("]"sv))
host = host.substring(1, host.length() - 2);
m_resolver->dns.lookup(host, DNS::Messages::Class::IN, { DNS::Messages::ResourceType::A, DNS::Messages::ResourceType::AAAA }) m_resolver->dns.lookup(host, DNS::Messages::Class::IN, { DNS::Messages::ResourceType::A, DNS::Messages::ResourceType::AAAA })
->when_rejected([this, request_id](auto const& error) { ->when_rejected([this, request_id](auto const& error) {
dbgln("StartRequest: DNS lookup failed: {}", error); dbgln("StartRequest: DNS lookup failed: {}", error);