fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 16:45:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWasm: Make memory.grow grow the memory's type

Browse Source 
After a `memory.grow`, the type of the memory instance should be
updated so potential memory imports on the boundary are unlinkable.
This commit is contained in:
Diego
2024-07-10 15:05:20 -07:00
committed by Ali Mohammad Pur
parent d07cf26894
commit 420a626554
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
Userland/Libraries/LibWasm/AbstractMachine/AbstractMachine.h
View File

@@ -410,7 +410,7 @@ public:
{
MemoryInstance instance { type };
if (!instance.grow(type.limits().min() * Constants::page_size))
if (!instance.grow(type.limits().min() * Constants::page_size, GrowType::No))
return Error::from_string_literal("Failed to grow to requested size");
return { move(instance) };
@@ -426,7 +426,12 @@ public:
Yes,
};
bool grow(size_t size_to_grow, InhibitGrowCallback inhibit_callback = InhibitGrowCallback::No)
enum class GrowType {
No,
Yes,
};
bool grow(size_t size_to_grow, GrowType grow_type = GrowType::Yes, InhibitGrowCallback inhibit_callback = InhibitGrowCallback::No)
{
if (size_to_grow == 0)
return true;
@@ -450,6 +455,14 @@ public:
if (inhibit_callback == InhibitGrowCallback::No && successful_grow_hook)
successful_grow_hook();
if (grow_type == GrowType::Yes) {
// Grow the memory's type. We do this when encountering a `memory.grow`.
//
// See relevant spec link:
// https://www.w3.org/TR/wasm-core-2/#growing-memories%E2%91%A0
m_type = MemoryType { Limits(m_type.limits().min() + size_to_grow / Constants::page_size, m_type.limits().max()) };
}
return true;
}