fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-04-23 21:14:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove a bunch of redundant Document::navigable() lookups

Browse Source 
Document::navigable() can be unpleasantly slow, since we don't have a
direct link between documents and navigables at the moment. So let's not
call it twice when once is enough.
This commit is contained in:
Andreas Kling
2024-03-16 09:24:57 +01:00
parent 77d98b5697
commit 43c720db81
4 changed files with 21 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/HTMLTitleElement.cpp
View File

@@ -29,8 +29,9 @@ void HTMLTitleElement::initialize(JS::Realm& realm)
void HTMLTitleElement::children_changed()
{
HTMLElement::children_changed();
if (navigable() && navigable()->is_traversable()) {
navigable()->traversable_navigable()->page().client().page_did_change_title(document().title().to_byte_string());
auto navigable = this->navigable();
if (navigable && navigable->is_traversable()) {
navigable->traversable_navigable()->page().client().page_did_change_title(document().title().to_byte_string());
}
}