fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 17:28:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't trim whitespace when checking for "module" type on scripts

Browse Source 
No major engine allows whitespace in the type when checking for
"module".

This was also reflected in the relevant web platform test, but not in
the spec.

The spec has been changed to match this behaviour: 23c723e3e9
This commit is contained in:
Luke Wilde
2021-09-07 08:12:41 +01:00
committed by Andreas Kling
parent 405b282bc3
commit 44b8afdbc4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLScriptElement.cpp
View File

@@ -126,12 +126,12 @@ void HTMLScriptElement::prepare_script()
|| (!has_type && !has_language)) {
script_block_type = "text/javascript";
} else if (has_type) {
script_block_type = attribute(HTML::AttributeNames::type).trim_whitespace();
script_block_type = attribute(HTML::AttributeNames::type);
} else if (!attribute(HTML::AttributeNames::language).is_empty()) {
script_block_type = String::formatted("text/{}", attribute(HTML::AttributeNames::language));
}
if (is_javascript_mime_type_essence_match(script_block_type)) {
if (is_javascript_mime_type_essence_match(script_block_type.trim_whitespace())) {
m_script_type = ScriptType::Classic;
} else if (script_block_type.equals_ignoring_case("module")) {
m_script_type = ScriptType::Module;