mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-26 11:20:03 +00:00
DevTools: Mark compilation-unit-only functions as static
This enables a nice warning in case a function becomes dead code. Also, in case of signal_trampoline_dummy, marking it external (non-static) prevents it from being 'optimized away', which would lead to surprising and weird linker errors.
This commit is contained in:
committed by
Andreas Kling
parent
84e112be6b
commit
5574d45eda
@@ -1124,7 +1124,7 @@ enum class DefaultSignalAction {
|
||||
Continue,
|
||||
};
|
||||
|
||||
DefaultSignalAction default_signal_action(int signal)
|
||||
static DefaultSignalAction default_signal_action(int signal)
|
||||
{
|
||||
ASSERT(signal && signal < NSIG);
|
||||
|
||||
@@ -1235,6 +1235,8 @@ void report(const char* format, ...)
|
||||
va_end(ap);
|
||||
}
|
||||
|
||||
// Make sure the compiler doesn't "optimize away" this function:
|
||||
extern void signal_trampoline_dummy(void);
|
||||
void signal_trampoline_dummy(void)
|
||||
{
|
||||
// The trampoline preserves the current eax, pushes the signal code and
|
||||
|
||||
Reference in New Issue
Block a user