fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-26 03:09:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Remove unused append_with_space etc functions from DOM::Node

Browse Source 
This change removes the append_without_space, append_with_space,
prepend_without_space, and prepend_with_space functions from DOM::Node.

All those methods were added with the initial “Implement Accessible Name
and Description Calculation” commit in da5c918 and were only used in the
code related to accessible-name computation. But subsequent changes to
that code have removed all the calls to those functions — so now they’re
all completely unused.
This commit is contained in:
sideshowbarker
2024-11-06 18:02:10 +09:00
committed by Andrew Kaster
parent eed20ad951
commit 55b19c3177
2 changed files with 0 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
Libraries/LibWeb/DOM/Node.cpp
View File

@@ -2472,62 +2472,6 @@ Optional<StringView> Node::first_valid_id(StringView value, Document const& docu
return {};
}
// https://www.w3.org/TR/accname-1.2/#mapping_additional_nd_te
ErrorOr<void> Node::append_without_space(StringBuilder x, StringView const& result)
{
// - If X is empty, copy the result to X.
// - If X is non-empty, copy the result to the end of X.
TRY(x.try_append(result));
return {};
}
// https://www.w3.org/TR/accname-1.2/#mapping_additional_nd_te
ErrorOr<void> Node::append_with_space(StringBuilder x, StringView const& result)
{
// - If X is empty, copy the result to X.
if (x.is_empty()) {
TRY(x.try_append(result));
} else {
// - If X is non-empty, add a space to the end of X and then copy the result to X after the space.
TRY(x.try_append(" "sv));
TRY(x.try_append(result));
}
return {};
}
// https://www.w3.org/TR/accname-1.2/#mapping_additional_nd_te
ErrorOr<void> Node::prepend_without_space(StringBuilder x, StringView const& result)
{
// - If X is empty, copy the result to X.
if (x.is_empty()) {
x.append(result);
} else {
// - If X is non-empty, copy the result to the start of X.
auto temp = TRY(x.to_string());
x.clear();
TRY(x.try_append(result));
TRY(x.try_append(temp));
}
return {};
}
// https://www.w3.org/TR/accname-1.2/#mapping_additional_nd_te
ErrorOr<void> Node::prepend_with_space(StringBuilder x, StringView const& result)
{
// - If X is empty, copy the result to X.
if (x.is_empty()) {
TRY(x.try_append(result));
} else {
// - If X is non-empty, copy the result to the start of X, and add a space after the copy.
auto temp = TRY(x.to_string());
x.clear();
TRY(x.try_append(result));
TRY(x.try_append(" "sv));
TRY(x.try_append(temp));
}
return {};
}
void Node::add_registered_observer(RegisteredObserver& registered_observer)
{
if (!m_registered_observer_list)