fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 16:45:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Update button/input activation behaviour to match spec

Browse Source
This commit is contained in:
Gingeh
2025-02-27 10:53:48 +11:00
committed by Tim Ledbetter
parent ddb832afdf
commit 591c6b0f68
6 changed files with 436 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Libraries/LibWeb/HTML/HTMLButtonElement.cpp
View File

@@ -137,14 +137,19 @@ void HTMLButtonElement::activation_behavior(DOM::Event const& event)
// 3. If element has a form owner:
if (form() != nullptr) {
// 1. If element is a submit button, then submit element's form owner from element with userInvolvement set to event's user navigation involvement.
// 1. If element is a submit button, then submit element's form owner from element with userInvolvement set to event's user navigation involvement, and return.
if (is_submit_button()) {
form()->submit_form(*this, { .user_involvement = user_navigation_involvement(event) }).release_value_but_fixme_should_propagate_errors();
return;
}
// 2. If element's type attribute is in the Reset Button state, then reset element's form owner.
// 2. If element's type attribute is in the Reset Button state, then reset element's form owner, and return.
if (type_state() == TypeAttributeState::Reset) {
form()->reset_form();
return;
}
// 3. If element's type attribute is in the Auto state, then return.
if (type_state() == TypeAttributeState::Auto)
return;
}
// FIXME: 4. Let target be the result of running element's get the commandfor associated element.

6
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -2696,7 +2696,11 @@ void HTMLInputElement::activation_behavior(DOM::Event const& event)
// 2. Run this element's input activation behavior, if any, and do nothing otherwise.
run_input_activation_behavior(event).release_value_but_fixme_should_propagate_errors();
// 3. Run the popover target attribute activation behavior given element and event's target.
// 3. If element has a form owner and element's type attribute is not in the Button state, then return.
if (form() != nullptr && type_state() != TypeAttributeState::Button)
return;
// 4. Run the popover target attribute activation behavior given element and event's target.
if (event.target() && event.target()->is_dom_node())
PopoverInvokerElement::popover_target_activation_behaviour(*this, as<DOM::Node>(*event.target()));
}