fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-03 15:16:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Reset message port receive state before dispatching events

Browse Source 
Dispatching events can cause arbitrary JS to run, which could cause the
event loop to be re-entered, or even post another message to the same
message port.
This commit is contained in:
Andrew Kaster
2024-01-05 14:50:01 -07:00
committed by Andreas Kling
parent 09ce32039f
commit 5ace712282
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/MessagePort.cpp
View File

@@ -297,8 +297,11 @@ void MessagePort::read_from_socket()
auto serialize_with_transfer_result = MUST(decoder.decode<SerializedTransferRecord>());
post_message_task_steps(serialize_with_transfer_result);
// Make sure to advance our state machine before dispatching the MessageEvent,
// as dispatching events can run arbitrary JS (and cause us to receive another message!)
m_socket_state = SocketState::Header;
post_message_task_steps(serialize_with_transfer_result);
break;
}
case SocketState::Error: