fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-02-19 22:25:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make MimeSniff::MimeType::parse() infallible

Browse Source 
It already returns an empty Optional for failures, so there's no need to
wrap it in an ErrorOr as well.
This commit is contained in:
Andreas Kling
2024-10-14 11:18:44 +02:00
committed by Andreas Kling
parent 88e7688940
commit 5c20bc2afc
15 changed files with 39 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View File

@@ -246,7 +246,7 @@ void HTMLObjectElement::resource_did_load()
// 2. If the type specified in the resource's Content-Type metadata is "text/plain", and the result of applying the rules for distinguishing if a resource is text or binary to the resource is that the resource is not text/plain, then set binary to true.
if (content_type == "text/plain"sv) {
auto supplied_type = MimeSniff::MimeType::parse(content_type).release_value_but_fixme_should_propagate_errors();
auto supplied_type = MimeSniff::MimeType::parse(content_type);
auto computed_type = MimeSniff::Resource::sniff(resource()->encoded_data(), MimeSniff::SniffingConfiguration {
.sniffing_context = MimeSniff::SniffingContext::TextOrBinary,
.supplied_type = move(supplied_type),
@@ -311,7 +311,7 @@ void HTMLObjectElement::run_object_representation_handler_steps(Optional<ByteStr
run_object_representation_fallback_steps();
return;
}
auto mime_type = MimeSniff::MimeType::parse(*resource_type).release_value_but_fixme_should_propagate_errors();
auto mime_type = MimeSniff::MimeType::parse(*resource_type);
// * If the resource type is an XML MIME type, or if the resource type does not start with "image/"
if (mime_type.has_value() && can_load_document_with_type(*mime_type) && (mime_type->is_xml() || !mime_type->is_image())) {