fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-27 19:59:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibGUI: Move shortcut actions from GEventLoop to GApplications.

Browse Source 
I'm gonna want to have nested event loops sooner or later, so let's not
pollute GEventLoop with things that are meant to work globally.

This patch also changes key events to pass around their modifiers as a
bitfield all the way around the system instead of breaking them up.
This commit is contained in:
Andreas Kling
2019-03-03 12:32:15 +01:00
parent 725b57fe1f
commit 5e40aa4f1a
11 changed files with 63 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
LibGUI/GAction.cpp
View File

@@ -1,5 +1,5 @@
#include <LibGUI/GAction.h>
#include <LibGUI/GEventLoop.h>
#include <LibGUI/GApplication.h>
GAction::GAction(const String& text, const String& custom_data, Function<void(const GAction&)> on_activation_callback)
: on_activation(move(on_activation_callback))
@@ -32,13 +32,13 @@ GAction::GAction(const String& text, const GShortcut& shortcut, RetainPtr<Graphi
, m_icon(move(icon))
, m_shortcut(shortcut)
{
GEventLoop::register_action_with_shortcut(Badge<GAction>(), *this);
GApplication::the().register_shortcut_action(Badge<GAction>(), *this);
}
GAction::~GAction()
{
if (m_shortcut.is_valid())
GEventLoop::unregister_action_with_shortcut(Badge<GAction>(), *this);
GApplication::the().unregister_shortcut_action(Badge<GAction>(), *this);
}
void GAction::activate()