mirror of
https://github.com/fergalmoran/ladybird.git
synced 2026-01-03 23:25:20 +00:00
AK+Everywhere: Rename String to DeprecatedString
We have a new, improved string type coming up in AK (OOM aware, no null state), and while it's going to use UTF-8, the name UTF8String is a mouthful - so let's free up the String name by renaming the existing class. Making the old one have an annoying name will hopefully also help with quick adoption :^)
This commit is contained in:
committed by
Andreas Kling
parent
f74251606d
commit
6e19ab2bbc
@@ -86,7 +86,7 @@ ErrorOr<Optional<ByteBuffer>> HeaderList::get(ReadonlyBytes name) const
|
||||
}
|
||||
|
||||
// https://fetch.spec.whatwg.org/#concept-header-list-get-decode-split
|
||||
ErrorOr<Optional<Vector<String>>> HeaderList::get_decode_and_split(ReadonlyBytes name) const
|
||||
ErrorOr<Optional<Vector<DeprecatedString>>> HeaderList::get_decode_and_split(ReadonlyBytes name) const
|
||||
{
|
||||
// To get, decode, and split a header name name from header list list, run these steps:
|
||||
|
||||
@@ -95,7 +95,7 @@ ErrorOr<Optional<Vector<String>>> HeaderList::get_decode_and_split(ReadonlyBytes
|
||||
|
||||
// 2. If initialValue is null, then return null.
|
||||
if (!initial_value.has_value())
|
||||
return Optional<Vector<String>> {};
|
||||
return Optional<Vector<DeprecatedString>> {};
|
||||
|
||||
// 3. Let input be the result of isomorphic decoding initialValue.
|
||||
auto input = StringView { *initial_value };
|
||||
@@ -104,7 +104,7 @@ ErrorOr<Optional<Vector<String>>> HeaderList::get_decode_and_split(ReadonlyBytes
|
||||
auto lexer = GenericLexer { input };
|
||||
|
||||
// 5. Let values be a list of strings, initially empty.
|
||||
Vector<String> values;
|
||||
Vector<DeprecatedString> values;
|
||||
|
||||
// 6. Let value be the empty string.
|
||||
StringBuilder value_builder;
|
||||
@@ -273,10 +273,10 @@ ErrorOr<Vector<Header>> HeaderList::sort_and_combine() const
|
||||
Optional<MimeSniff::MimeType> HeaderList::extract_mime_type() const
|
||||
{
|
||||
// 1. Let charset be null.
|
||||
Optional<String> charset;
|
||||
Optional<DeprecatedString> charset;
|
||||
|
||||
// 2. Let essence be null.
|
||||
Optional<String> essence;
|
||||
Optional<DeprecatedString> essence;
|
||||
|
||||
// 3. Let mimeType be null.
|
||||
Optional<MimeSniff::MimeType> mime_type;
|
||||
|
||||
Reference in New Issue
Block a user