fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 08:36:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/CSS: Insert whitespace between tokens in serialized UnresolvedSV

Browse Source 
Otherwise, `margin: var(--foo) var(--bar)` would be wrongly serialized
as `margin: var(--foo)var(--bar)`
This commit is contained in:
Sam Atkins
2024-10-15 10:21:40 +01:00
committed by Andreas Kling
parent bf3e6daedb
commit 6e68e8f3c9
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/css/attr-serialization.txt
View File

@@ -6,3 +6,4 @@ attr(foo string)
attr( foo string ) attr( foo string )
attr(foo string, "fallback") attr(foo string, "fallback")
attr( foo string , "fallback" ) attr( foo string , "fallback" )
attr(foo) attr(bar) attr(baz)

1
Tests/LibWeb/Text/input/css/attr-serialization.html
View File

@@ -18,5 +18,6 @@
serialize('attr(foo string, "fallback")'); serialize('attr(foo string, "fallback")');
// FIXME: This should produce `attr(foo string, "fallback")` but doesn't yet. // FIXME: This should produce `attr(foo string, "fallback")` but doesn't yet.
serialize('attr( foo string , "fallback" )'); serialize('attr( foo string , "fallback" )');
serialize(' attr(foo) attr(bar) attr(baz) ');
}); });
</script> </script>

5
Userland/Libraries/LibWeb/CSS/StyleValues/UnresolvedStyleValue.cpp
View File

@@ -17,10 +17,7 @@ String UnresolvedStyleValue::to_string() const
if (m_original_source_text.has_value()) if (m_original_source_text.has_value())
return *m_original_source_text; return *m_original_source_text;
StringBuilder builder; return MUST(String::join(' ', m_values));
for (auto& value : m_values)
builder.append(value.to_string());
return MUST(builder.to_string());
} }
bool UnresolvedStyleValue::equals(CSSStyleValue const& other) const bool UnresolvedStyleValue::equals(CSSStyleValue const& other) const