fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use finalize for cleaning up all navigables

Browse Source 
The use of this HashMap looks very spooky, but let's at least use
finalize when cleaning them up on destruction to make things slightly
less dangerous looking.
This commit is contained in:
Shannon Booth
2025-01-17 14:18:36 +13:00
committed by Andreas Kling
parent 59162c8155
commit 76397c9ecd
7 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Libraries/LibWeb/HTML/Navigable.cpp
View File

@@ -73,9 +73,9 @@ private:
GC_DEFINE_ALLOCATOR(ResponseHolder);
HashTable<Navigable*>& all_navigables()
HashTable<GC::RawRef<Navigable>>& all_navigables()
{
static HashTable<Navigable*> set;
static HashTable<GC::RawRef<Navigable>> set;
return set;
}
@@ -111,12 +111,15 @@ Navigable::Navigable(GC::Ref<Page> page)
: m_page(page)
, m_event_handler({}, *this)
{
all_navigables().set(this);
all_navigables().set(*this);
}
Navigable::~Navigable()
Navigable::~Navigable() = default;
void Navigable::finalize()
{
all_navigables().remove(this);
all_navigables().remove(*this);
Base::finalize();
}
void Navigable::visit_edges(Cell::Visitor& visitor)
@@ -159,7 +162,7 @@ void Navigable::set_delaying_load_events(bool value)
GC::Ptr<Navigable> Navigable::navigable_with_active_document(GC::Ref<DOM::Document> document)
{
for (auto* navigable : all_navigables()) {
for (auto navigable : all_navigables()) {
if (navigable->active_document() == document)
return navigable;
}