mirror of
https://github.com/fergalmoran/ladybird.git
synced 2026-02-25 00:54:32 +00:00
Everywhere: Switch from (void) to [[maybe_unused]] (#4473)
Problem: - `(void)` simply casts the expression to void. This is understood to indicate that it is ignored, but this is really a compiler trick to get the compiler to not generate a warning. Solution: - Use the `[[maybe_unused]]` attribute to indicate the value is unused. Note: - Functions taking a `(void)` argument list have also been changed to `()` because this is not needed and shows up in the same grep command.
This commit is contained in:
@@ -166,7 +166,7 @@ bool Decoder::decode(Dictionary& dictionary)
|
||||
return true;
|
||||
}
|
||||
|
||||
bool Decoder::decode(File& file)
|
||||
bool Decoder::decode([[maybe_unused]] File& file)
|
||||
{
|
||||
#ifdef __serenity__
|
||||
int fd = recvfd(m_sockfd);
|
||||
@@ -177,8 +177,7 @@ bool Decoder::decode(File& file)
|
||||
file = File(fd);
|
||||
return true;
|
||||
#else
|
||||
(void)file;
|
||||
(void)m_sockfd;
|
||||
[[maybe_unused]] auto fd = m_sockfd;
|
||||
warnln("fd passing is not supported on this platform, sorry :(");
|
||||
return false;
|
||||
#endif
|
||||
|
||||
Reference in New Issue
Block a user