mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-22 17:28:30 +00:00
LibJS: Correctly return cached value for global var bindings
When the cached value was not an accessor, it was simply ignored. This is the value we really want, so we can just return it. Shows up to 5x improvements on some benchmarks, and 1.4x in general js-benchmarks.
This commit is contained in:
committed by
Andreas Kling
parent
b6a5b7e186
commit
77a46ab1b8
@@ -1118,6 +1118,7 @@ inline ThrowCompletionOr<Value> get_global(Interpreter& interpreter, IdentifierT
|
||||
auto value = binding_object.get_direct(cache.property_offset.value());
|
||||
if (value.is_accessor())
|
||||
return TRY(call(vm, value.as_accessor().getter(), js_undefined()));
|
||||
return value;
|
||||
}
|
||||
|
||||
// OPTIMIZATION: For global lexical bindings, if the global declarative environment hasn't changed,
|
||||
|
||||
Reference in New Issue
Block a user