fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-24 02:09:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Only use maxlength <input> attribute when applicable

Browse Source
This commit is contained in:
Shannon Booth
2025-01-15 22:12:57 +13:00
committed by Jelle Raaijmakers
parent 5aeae5e583
commit 7b637b1eee
3 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -2,7 +2,7 @@
* Copyright (c) 2018-2023, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2022, Adam Hodgen <ant1441@gmail.com>
* Copyright (c) 2022, Andrew Kaster <akaster@serenityos.org>
* Copyright (c) 2023-2024, Shannon Booth <shannon@serenityos.org>
* Copyright (c) 2023-2025, Shannon Booth <shannon@serenityos.org>
* Copyright (c) 2023, Bastiaan van der Plaat <bastiaan.v.d.plaat@gmail.com>
* Copyright (c) 2024, Jelle Raaijmakers <jelle@ladybird.org>
* Copyright (c) 2024, Fernando Kiotheka <fer@k6a.dev>
@@ -721,10 +721,27 @@ static bool is_allowed_to_be_readonly(HTML::HTMLInputElement::TypeAttributeState
}
}
// https://html.spec.whatwg.org/multipage/input.html#the-input-element:attr-input-maxlength-3
static bool is_applicable_for_maxlength_attribute(HTML::HTMLInputElement::TypeAttributeState state)
{
switch (state) {
case HTML::HTMLInputElement::TypeAttributeState::Text:
case HTML::HTMLInputElement::TypeAttributeState::Search:
case HTML::HTMLInputElement::TypeAttributeState::Telephone:
case HTML::HTMLInputElement::TypeAttributeState::URL:
case HTML::HTMLInputElement::TypeAttributeState::Email:
case HTML::HTMLInputElement::TypeAttributeState::Password:
return true;
default:
return false;
}
}
// https://html.spec.whatwg.org/multipage/input.html#attr-input-maxlength
void HTMLInputElement::handle_maxlength_attribute()
{
if (m_text_node) {
// The maxlength attribute, when it applies, is a form control maxlength attribute.
if (m_text_node && is_applicable_for_maxlength_attribute(type_state())) {
auto max_length = this->max_length();
if (max_length >= 0) {
m_text_node->set_max_length(max_length);