fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-03-06 13:35:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibGfx+LibIPC: Add Gfx::ShareableBitmap, a bitmap for easy IPC usage

Browse Source 
With this patch, it's now possible to pass a Gfx::ShareableBitmap in an
IPC message. As long as the message itself is synchronous, the bitmap
will be adopted by the receiving end, and disowned by the sender nicely
without any accounting effort like we've had to do in the past.

Use this in NotificationServer to allow sending arbitrary bitmaps as
icons instead of paths-to-icons.
This commit is contained in:
Andreas Kling
2020-03-29 19:04:05 +02:00
parent 24a0354ce8
commit 7cfe712f4d
17 changed files with 115 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Servers/NotificationServer/NotificationWindow.cpp
View File

@@ -33,6 +33,7 @@
#include <LibGUI/Widget.h>
#include <LibGfx/Bitmap.h>
#include <LibGfx/Font.h>
#include <LibGfx/ShareableBitmap.h>
namespace NotificationServer {
@@ -55,7 +56,7 @@ void update_notification_window_locations()
}
}
NotificationWindow::NotificationWindow(const String& text, const String& title, const String& icon_path)
NotificationWindow::NotificationWindow(const String& text, const String& title, const Gfx::ShareableBitmap& icon)
{
s_windows.append(this);
@@ -86,11 +87,11 @@ NotificationWindow::NotificationWindow(const String& text, const String& title,
widget.layout()->set_margins({ 8, 8, 8, 8 });
widget.layout()->set_spacing(6);
if (auto icon = Gfx::Bitmap::load_from_file(icon_path)) {
if (icon.is_valid()) {
auto& icon_label = widget.add<GUI::Label>();
icon_label.set_size_policy(GUI::SizePolicy::Fixed, GUI::SizePolicy::Fixed);
icon_label.set_preferred_size(32, 32);
icon_label.set_icon(icon);
icon_label.set_icon(icon.bitmap());
}
auto& left_container = widget.add<GUI::Widget>();