fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Postpone invalidating style of elements affected by :has()

Browse Source 
...until Document::update_style(). This allows to avoid doing full
document DOM tree traversal on each Node::invalidate_style() call.

Fixes performance regression on wpt.fyi
This commit is contained in:
Aliaksandr Kalenik
2025-01-29 15:39:15 +01:00
committed by Andreas Kling
parent 8877a4f691
commit 7da3b06e3e
4 changed files with 48 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/DOM/Document.h
View File

@@ -510,6 +510,9 @@ public:
[[nodiscard]] bool needs_full_layout_tree_update() const { return m_needs_full_layout_tree_update; }
void set_needs_full_layout_tree_update(bool b) { m_needs_full_layout_tree_update = b; }
bool needs_invalidate_elements_affected_by_has() const { return m_needs_invalidate_elements_affected_by_has; }
void set_needs_invalidate_elements_affected_by_has(bool b) { m_needs_invalidate_elements_affected_by_has = b; }
void set_needs_to_refresh_scroll_state(bool b);
bool has_active_favicon() const { return m_active_favicon; }
@@ -805,6 +808,8 @@ private:
// ^HTML::GlobalEventHandlers
virtual GC::Ptr<EventTarget> global_event_handlers_to_event_target(FlyString const&) final { return *this; }
void invalidate_elements_affected_by_has();
void tear_down_layout_tree();
void update_active_element();
@@ -945,6 +950,7 @@ private:
bool m_needs_full_style_update { false };
bool m_needs_full_layout_tree_update { false };
bool m_needs_invalidate_elements_affected_by_has { false };
bool m_needs_animated_style_update { false };