mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-27 11:48:32 +00:00
LibWeb: Move setting of Web object prototypes to initialize()
This needs to happen before prototype/constructor intitialization can be made lazy. Otherwise, GC could run during the C++ constructor and try to collect the object currently being created.
This commit is contained in:
committed by
Andreas Kling
parent
7bd8fd000f
commit
834202aeb9
@@ -17,11 +17,16 @@ namespace Web::HTML {
|
||||
HTMLProgressElement::HTMLProgressElement(DOM::Document& document, DOM::QualifiedName qualified_name)
|
||||
: HTMLElement(document, move(qualified_name))
|
||||
{
|
||||
set_prototype(&Bindings::cached_web_prototype(realm(), "HTMLProgressElement"));
|
||||
}
|
||||
|
||||
HTMLProgressElement::~HTMLProgressElement() = default;
|
||||
|
||||
void HTMLProgressElement::initialize(JS::Realm& realm)
|
||||
{
|
||||
Base::initialize(realm);
|
||||
set_prototype(&Bindings::ensure_web_prototype<Bindings::HTMLProgressElementPrototype>(realm, "HTMLProgressElement"));
|
||||
}
|
||||
|
||||
JS::GCPtr<Layout::Node> HTMLProgressElement::create_layout_node(NonnullRefPtr<CSS::StyleProperties> style)
|
||||
{
|
||||
if (style->appearance().value_or(CSS::Appearance::Auto) == CSS::Appearance::None)
|
||||
|
||||
Reference in New Issue
Block a user