fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-22 09:19:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Inline more of cached environment variable access in interpreter

Browse Source 
And stop passing VM strictness to direct access, since it doesn't care
about strictness anyway.
This commit is contained in:
Andreas Kling
2024-05-11 17:22:59 +02:00
parent 9b6a1de777
commit 8447f6f6da
6 changed files with 42 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Userland/Libraries/LibJS/Bytecode/Interpreter.cpp
View File

@@ -1232,7 +1232,25 @@ ThrowCompletionOr<void> ConcatString::execute_impl(Bytecode::Interpreter& interp
ThrowCompletionOr<void> GetVariable::execute_impl(Bytecode::Interpreter& interpreter) const
{
interpreter.set(dst(), TRY(get_variable(interpreter, interpreter.current_executable().get_identifier(m_identifier), interpreter.current_executable().environment_variable_caches[m_cache_index])));
auto& vm = interpreter.vm();
auto& executable = interpreter.current_executable();
auto& cache = executable.environment_variable_caches[m_cache_index];
if (cache.has_value()) {
auto const* environment = vm.running_execution_context().lexical_environment.ptr();
for (size_t i = 0; i < cache->hops; ++i)
environment = environment->outer_environment();
if (!environment->is_permanently_screwed_by_eval()) {
interpreter.set(dst(), TRY(static_cast<DeclarativeEnvironment const&>(*environment).get_binding_value_direct(vm, cache.value().index)));
return {};
}
cache = {};
}
auto reference = TRY(vm.resolve_binding(executable.get_identifier(m_identifier)));
if (reference.environment_coordinate().has_value())
cache = reference.environment_coordinate();
interpreter.set(dst(), TRY(reference.get_value(vm)));
return {};
}