fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 16:45:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Move "natural size" concept into Layout::Box

Browse Source 
Having this here instead of in ReplacedBox means we can access it when
figuring out what the "preferred aspect ratio" is.

There's some inconsistency between specs about what this is called, but
they're moving towards referring to this as "natural width/height/
aspect-ratio", so let's copy that terminology.
This commit is contained in:
Sam Atkins
2023-06-08 15:56:28 +01:00
committed by Andreas Kling
parent 6fd3b39bef
commit 84e7216603
13 changed files with 75 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Layout/ImageBox.cpp
View File

@@ -23,9 +23,9 @@ ImageBox::~ImageBox() = default;
void ImageBox::prepare_for_replaced_layout()
{
set_intrinsic_width(m_image_provider.intrinsic_width());
set_intrinsic_height(m_image_provider.intrinsic_height());
set_intrinsic_aspect_ratio(m_image_provider.intrinsic_aspect_ratio());
set_natural_width(m_image_provider.intrinsic_width());
set_natural_height(m_image_provider.intrinsic_height());
set_natural_aspect_ratio(m_image_provider.intrinsic_aspect_ratio());
if (renders_as_alt_text()) {
auto& image_element = verify_cast<HTML::HTMLImageElement>(dom_node());
@@ -37,11 +37,11 @@ void ImageBox::prepare_for_replaced_layout()
m_cached_alt_text_width = font.width(alt);
alt_text_width = m_cached_alt_text_width.value();
set_intrinsic_width(alt_text_width + 16);
set_intrinsic_height(font.pixel_size() + 16);
set_natural_width(alt_text_width + 16);
set_natural_height(font.pixel_size() + 16);
}
if (!has_intrinsic_width() && !has_intrinsic_height()) {
if (!has_natural_width() && !has_natural_height()) {
// FIXME: Do something.
}
}