fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2025-12-30 05:08:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Move DOM event dispatch to its own class

Browse Source 
For now, the new DOM::EventDispatcher is very simple, it just iterates
over the set of listeners on an EventTarget and invokes the callbacks
as it goes.

This simplifies EventTarget subclasses since they no longer have to
implement the callback mechanism themselves.
This commit is contained in:
Andreas Kling
2020-09-06 14:28:41 +02:00
parent 521475dc01
commit 8a6a9a8fb6
10 changed files with 185 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
Libraries/LibWeb/DOM/Node.cpp
View File

@@ -36,6 +36,7 @@
#include <LibWeb/CSS/StyleResolver.h>
#include <LibWeb/DOM/Element.h>
#include <LibWeb/DOM/Event.h>
#include <LibWeb/DOM/EventDispatcher.h>
#include <LibWeb/DOM/EventListener.h>
#include <LibWeb/DOM/Node.h>
#include <LibWeb/HTML/HTMLAnchorElement.h>
@@ -119,25 +120,7 @@ bool Node::is_link() const
void Node::dispatch_event(NonnullRefPtr<Event> event)
{
for (auto& listener : listeners()) {
if (listener.event_name == event->type()) {
auto& function = const_cast<EventListener&>(*listener.listener).function();
#ifdef EVENT_DEBUG
static_cast<const JS::ScriptFunction&>(function).body().dump(0);
#endif
auto& global_object = function.global_object();
auto* this_value = wrap(global_object, *this);
#ifdef EVENT_DEBUG
dbg() << "calling event listener with this=" << this_value;
#endif
auto* event_wrapper = wrap(global_object, *event);
auto& interpreter = document().interpreter();
(void)interpreter.call(function, this_value, event_wrapper);
if (interpreter.exception())
interpreter.clear_exception();
}
}
EventDispatcher::dispatch(*this, event);
// FIXME: This is a hack. We should follow the real rules of event bubbling.
if (parent())
parent()->dispatch_event(move(event));
@@ -218,4 +201,9 @@ bool Node::is_editable() const
return parent() && parent()->is_editable();
}
Bindings::EventTargetWrapper* Node::create_wrapper(JS::GlobalObject& global_object)
{
return wrap(global_object, *this);
}
}