fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-06 08:36:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add save and restore commands in recording painter

Browse Source 
This change is a preparation before introducing Skia painter in an
upcoming change. It's needed because Skia does not have an API to
implement ClearClipRect command. It only allows to return previous
clip rect by popping from its internal state stack.

A bit more context: initially we had save and restore commands, but
their frequent use led to many reallocations of vector during painting
commands recording. To resolve this, we switched to SegmentedVector to
store commands list, which allows fast appends. Now, having many save
and restore commands no longer causes noticeable performance issue.
This commit is contained in:
Aliaksandr Kalenik
2024-06-10 14:18:32 +03:00
committed by Andreas Kling
parent 0e705f431e
commit 8a7cd8055f
10 changed files with 58 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Userland/Libraries/LibWeb/Painting/CommandList.cpp
View File

@@ -63,8 +63,8 @@ void CommandList::mark_unnecessary_commands()
m_commands[command_index].skip = true;
}
} else {
// SetClipRect and ClearClipRect commands do not produce visible output
auto update_clip_command = command.has<SetClipRect>() || command.has<ClearClipRect>();
// Save, Restore and AddClipRect commands do not produce visible output
auto update_clip_command = command.has<Save>() || command.has<Restore>() || command.has<AddClipRect>();
if (sample_blit_ranges.size() > 0 && !update_clip_command) {
// If painting command is found for sample_under_corners command on top of the stack, then all
// sample_under_corners commands below should also not be skipped.
@@ -154,8 +154,9 @@ void CommandList::execute(CommandExecutor& executor)
else HANDLE_COMMAND(FillRect, fill_rect)
else HANDLE_COMMAND(DrawScaledBitmap, draw_scaled_bitmap)
else HANDLE_COMMAND(DrawScaledImmutableBitmap, draw_scaled_immutable_bitmap)
else HANDLE_COMMAND(SetClipRect, set_clip_rect)
else HANDLE_COMMAND(ClearClipRect, clear_clip_rect)
else HANDLE_COMMAND(AddClipRect, add_clip_rect)
else HANDLE_COMMAND(Save, save)
else HANDLE_COMMAND(Restore, restore)
else HANDLE_COMMAND(PushStackingContext, push_stacking_context)
else HANDLE_COMMAND(PopStackingContext, pop_stacking_context)
else HANDLE_COMMAND(PaintLinearGradient, paint_linear_gradient)