fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-03 23:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+LibWebView+WebContent: Add a new IPC for modifying history state

Browse Source 
Let's not re-invoke the "page did start loading" IPC when the history
state is pushed/replaced. It's a bit misleading (the change does not
actually load the new URL), but also the chromes may do more work than
we want when we change the URL.

Instead, add a new IPC for the history object to invoke.
This commit is contained in:
Timothy Flynn
2024-03-28 22:12:23 -04:00
committed by Tim Flynn
parent 1767f405dc
commit 8b1ad5c496
9 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/History.cpp
View File

@@ -209,7 +209,7 @@ WebIDL::ExceptionOr<void> History::shared_history_push_replace_state(JS::Value d
auto navigable = document->navigable();
if (navigable->is_top_level_traversable()) {
navigable->active_browsing_context()->page().client().page_did_start_loading(new_url, false);
navigable->active_browsing_context()->page().client().page_did_update_url(new_url, history_handling);
}
// 10. Run the URL and history update steps given document and newURL, with serializedData set to